fix(file_util::pick): ensure files are readable before picking them #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the firmware of the Lenovo X13s does not expose charge_now or charge_full, but the files still exist, so file_util::pick() will still choose that over energy_now/energy_full. This leads to the battery module erroneously outputting "0%" at all times. If charge_now or charge_full is read, it will return ENODATA, so simply reading 1 char and checking the status should determine if the file should actually be picked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The firmware of the Lenovo X13s does not expose
charge_noworcharge_full, but the files still exist, sofile_util::pick()will still choose that overenergy_now/energy_full. This leads to the battery module erroneously outputting "0%" at all times. Ifcharge_noworcharge_fullis read, it will returnENODATA, so simply reading 1 char and checking the status should determine if the file should actually be picked.Related Issues & Documents
Documentation (check all applicable)