-
-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config value #3033
base: master
Are you sure you want to change the base?
Config value #3033
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3033 /- ##
==========================================
Coverage 12.69% 15.24% 2.54%
==========================================
Files 160 160
Lines 12533 12760 227
==========================================
Hits 1591 1945 354
Misses 10942 10815 -127
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This looks very promising :D I unfortunately don't really have time to review this right now, any spare time I have, I want to put into finishing the next release. But in general, I very much agree with the concept of giving modules a view of their own section without them having to select their section every time And of course the testing infrastructure will also be very useful ;) |
What type of PR is this? (check all applicable)
Description
This PR introduces the
config::value
type and use it all over polybar.Instead of reading configuration values from concatenation of string keys to form the whole key,
config::value
provides a[]
operator used to compose new keys.Related Issues & Documents
This is a preliminary refactor towards a new configuration format and #2391
Documentation (check all applicable)