Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim details to the summary, expand shows all #1197

Merged
merged 4 commits into from
May 24, 2019
Merged

Trim details to the summary, expand shows all #1197

merged 4 commits into from
May 24, 2019

Conversation

pbteja1998
Copy link
Contributor

Resolves #1005

1
Screenshot from 2019-05-24 13-42-56

@pbteja1998 pbteja1998 mentioned this pull request May 24, 2019
Closed
jacogr
jacogr requested changes May 24, 2019
View reviewed changes
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! A small comment to make it apply everywhere.

packages/app-explorer/src/index.css Outdated Show resolved Hide resolved
@pbteja1998
Copy link
Contributor Author

@jacogr Moved the styles to app.css

jacogr
jacogr approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, does exactly what it says on the box. Thank you.

I think details > summary could do with an outline: none to just cleanup the UI a bit.

@pbteja1998
Copy link
Contributor Author

added outline:none

@jacogr jacogr merged commit f9501aa into polkadot-js:master May 24, 2019
@pbteja1998 pbteja1998 deleted the trim-details branch May 24, 2019 09:42
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacogr jacogr jacogr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trim details to the summary, expand shows all
3 participants
@pbteja1998 @polkadot-js-bot @jacogr