Turn on strict concurrency. #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package.swift
Outdated
| @@ -27,35 27,38 @@ let package = Package( | |||
| "PerceptionMacros", | |||
| .product(name: "OrderedCollections", package: "swift-collections"), | |||
| .product(name: "XCTestDynamicOverlay", package: "xctest-dynamic-overlay"), | |||
| ], | |||
| swiftSettings: [ | |||
| .enableExperimentalFeature("StrictConcurrency") | |||
There was a problem hiding this comment.
Let's tag this branch with a pseudo-release so that we can confirm that this doesn't break downstream builds.
stephencelis
approved these changes
Apr 11, 2024
|
Might be worth turning on GlobalConcurrency too? |
|
Hi @Brett-Best, thanks for the suggestion! I can definitely add that, but it also seems to be a subset of StrictConcurrency as far as I can tell. I get the global mutable state warning when only StrictConcurrency is specified in Package.swift. Are you aware of anything that GlobalConcurrency surfaces that is not covered by StrictConcurrency? |
|
Ah, looks like it's enabled implicitly when StrictConcurrency is on 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.