feat(deps): migrate js-yaml to yaml #8326
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We use a fork of js-yaml with some changes added for pnpm specifically. Like formatting some fields in the lockfile the way we want. |
Ok, so we also fork/patch yaml and implement the same changes… @zkochan Is it just the commits listed here? What are the important changes? Are there tests against them? |
|
IIRC the changes were related to formatting. There is probably just one test that checks the format of the generated lockfile: https://github.com/pnpm/pnpm/blob/main/lockfile/lockfile-file/test/__snapshots__/write.test.ts.snap |
|
ok, done |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yaml is a better library, and handles comments much better than js-yaml, which is no longer maintained, since ~3 years now.
Precondition for #6273. Also related to zkochan/packages#198.