Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code duplication in parallel projects #23

Closed
Boudewijn26 opened this issue Jan 19, 2016 · 6 comments
Closed

Code duplication in parallel projects #23

Boudewijn26 opened this issue Jan 19, 2016 · 6 comments

Comments

@Boudewijn26
Copy link
Contributor

Currently google_speech uses the same token generation code as this project. Is it worthwhile to extract the token generation code from this project into a new project and let both projects depend on that? I would be willing to maintain that project.
@desbma
Copy link
Contributor

desbma commented Jan 21, 2016

Sounds like a good idea to me, especially if Google starts changing the hash algorithm.

@pndurette
Copy link
Owner

Agreed! That project wouldn't do much on its own, but I'm sure there's more than us two who are using this endpoint.

Pierre Nick Durette
Sent from mobile

On Jan 21, 2016, at 6:45 AM, desbma [email protected] wrote:

Sounds like a good idea to me, especially if Google starts changing the hash algorithm.

—
Reply to this email directly or view it on GitHub.

@Boudewijn26
Copy link
Contributor Author

I think we are live.

@pndurette
Copy link
Owner

Amazing! Thanks for that. I'll implement it soon.
On Sat, Jan 30, 2016 at 11:24 AM Boudewijn van groos <
[email protected]> wrote:

I think we are live. https://pypi.python.org/pypi/gTTS-token/1.0.0

—
Reply to this email directly or view it on GitHub
#23 (comment).

@pndurette
Copy link
Owner

I was away for a while and totally let this drag on.. I want to do this later today. I see you're already at 1.0.1! I will let the requirement for gTTS-token lonely constrained in setup.py.

@pndurette
Copy link
Owner

Done. gTTS 1.1.4 is live! Thanks for you work on this @Boudewijn26 . v1.1.3...v1.1.4

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@desbma @pndurette @Boudewijn26