[java] Fix #4477: A false-positive about SignatureDeclareThrowsException #4488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
jsotuyod
reviewed
Apr 21, 2023
Comment on lines
82
to
83
| || method.isAnnotationPresent("org.testng.annotations.AfterClass") | ||
| || method.isAnnotationPresent("org.testng.annotations.BeforeClass") |
There was a problem hiding this comment.
nice catch! There are however a bunch of other TestNG annotations that are missing:
@BeforeMethod, @AfterMethod, @BeforeGroup, @AfterGroup, @BeforeTest, @AfterTest, @BeforeSuite and @AfterSuite…
To keep this method manageable, we probably want to move all these annotation name Strings (both for junit and testng) to a private static immutable Set<String>, and replace all these method.isAnnotationPresent with something along the lines:
return TEST_CONFIGURATION_ANNOTATIONS.stream().anyMatch(method::isAnnotationPresent)
|| …There was a problem hiding this comment.
Thanks for comment. I will revise it later.
jsotuyod
changed the title
|
Thanks! I'll merge after a couple minor edits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR excludes
org.testng.annotations.AfterClassandorg.testng.annotations.BeforeClasswhich cause FP when using in a unit test method and throwing an exception is allowed.Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)