Feature/goals bar text #1165
Merged
Feature/goals bar text #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This change adds two new commands to gracefully stop and remove the Postgres and Clickhouse docker containers. To do so, it also gives them a recognizable name. * Additionally, the Postgres container is updated to use a named volume for its data. This lower friction for repeat contributions where one would otherwise sign up and activate their accounts again and again each time.
This fixes two issues from plausible#972 - Goals area has display issues depending on the name of your custom events - It is not possible to view labels for outbound links, 404 and custom props
|
PR is up-to-date with the latest |
ukutaht
requested changes
Jul 6, 2021
ukutaht
reviewed
Jul 6, 2021
Hyperlinks (<a>) inherit their color. In the case of the root conversion text, we needed to specify the color somewhere. The same color as the breakdown texts has been chosen. The Bar component no longer needs to take in text classes.
ukutaht
approved these changes
Jul 8, 2021
|
Amazing, thank you @hirusi! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes two issues from #972:
Some screenshots:
Totals are hidden on mobile:
When text spills over, Bar updates its height naturally:
I would also recommend testing every single place that uses a bar, since this PR touches every single place. :)
Tests
Changelog
Documentation