Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rock tags does not show all tags #4

Open
hhrutter opened this issue Sep 24, 2017 · 1 comment
Open

rock tags does not show all tags #4

hhrutter opened this issue Sep 24, 2017 · 1 comment

Comments

@hhrutter
Copy link

This should not be a duplicate of #3 since I am not using packed tags in http://github.com/hhrutter/pdfcpu but

rock tags

returns an incomplete tag list compared to

git tag -l

and for my checked out pkg/rock it returns an empty list.

Looks like an issue with gogits.
necrophonic added a commit to necrophonic/rock that referenced this issue Oct 12, 2017
@necrophonic
Fix pkg#3 and pkg#4 incomplete and packed refs
3a96e14 
The original git library dependency (github.com/gogits/git) did not correctly handle refs that have been packed.
Pull request was made to address but appears that repo is no longer in active development.

This PR proposes switching to use the code.gitea.io/git lib (from which the original dependency was forked) as this correctly identifies the tags.
@necrophonic necrophonic mentioned this issue Oct 12, 2017
Closed
@necrophonic
Copy link
Contributor

Hopefully addressed in pr #8

@hhrutter Cloning your repo and running patched code produces: (compared to git tag -l command - correct at time of writing)

$ rock tags
Existing Tags:
v0.0.7
v0.0.6
v0.0.5
v0.0.4
v0.0.3
v0.0.2
v0.0.1

$ git tag -l
v0.0.1
v0.0.2
v0.0.3
v0.0.4
v0.0.5
v0.0.6
v0.0.7

Order is reversed but all the tags seem to be there?

bketelsen added a commit that referenced this issue Nov 7, 2017
@bketelsen
Merge pull request #8 from necrophonic/fix-packed-refs
606d2b3 
Fix #3 and #4 incomplete and packed refs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@necrophonic @hhrutter