Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): Fixed multiple store not working when alias is a collection #62

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

pjechris
Copy link
Owner

⚽️ Description

Fix a regression where alias was failing to be restored when it is a collection. This is because alias was already marked as updated, which it indeed was but not with the expected value.

🔨 Implementation details

For now the fix is to store alias first. In future would be good to only store alias when there's one. This would avoid a useless call.

@pjechris pjechris added the bug Something isn't working label Dec 19, 2023
@pjechris pjechris merged commit c2aeb3c into main Dec 19, 2023
2 checks passed
@pjechris pjechris deleted the fix/alias-notUpdated branch December 19, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant