Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alias): Fix alias not enqueued when one object in collection changes #60

Merged
merged 2 commits into from
Oct 23, 2023
Merged

fix(alias): Fix alias not enqueued when one object in collection changes #60

merged 2 commits into from
Oct 23, 2023

Conversation

pjechris
Copy link
Owner

⚽️ Description

Fixed a bug with new alias system where alias was not enqueued as modified.

🔨 Implementation details

  • Removed "double" storing in update: we were doing nodeStore storeAlias which was then sometimes missing some entities
  • Added missing onChange when creating alias node

@pjechris pjechris added the bug Something isn't working label Oct 20, 2023
@pjechris pjechris merged commit 9b9d85b into main Oct 23, 2023
2 checks passed
@pjechris pjechris deleted the fix/alias-update-relationships branch October 23, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pjechris