Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech(observer): Use registry to observe arrays #57

Merged
merged 10 commits into from
Sep 4, 2023

Conversation

pjechris
Copy link
Owner

@pjechris pjechris commented Sep 1, 2023

⚽️ Description

Use ObserverRegistry to handle array observation. This allows to avoid having multiple update notifications for arrays. This also fix "regression" from previous MR which triggered n notifications for initial value.

🔨 Implementation details

  • Added addObserver for arrays
  • Registry observers are now objects and named Handler
  • Handler is shared across each array objects
  • postChanges check a handler is called only once

@pjechris pjechris added the tech label Sep 1, 2023
@pjechris pjechris merged commit d2ab63e into main Sep 4, 2023
2 checks passed
@pjechris pjechris deleted the tech/registry-collections-executeOnce branch September 4, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant