Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech(observation): Enqueue modifications in ObservationRegistry #54

Merged
merged 10 commits into from
Aug 8, 2023

Conversation

pjechris
Copy link
Owner

@pjechris pjechris commented Aug 7, 2023

⚽️ Description

Instead of post changes one by one, now modifications are enqueued and posted once store/update is finished.

🔨 Implementation details

  • 💥 Post is asynchronous. This was already the case but now it's also the case for the first value
  • 💥 Now both EntityObserver Publisher and regular EntityObserver post the first value
  • Tests were updated to check we don't trigger too many changes
  • Tests were updated to make sure we trigger changes for all stored/updated types
  • Changes are computed at the time of postChanges is called. Any subsequent changes will be posted in next call

@pjechris pjechris added breaking change Code that add significant changes tech labels Aug 7, 2023
@pjechris pjechris merged commit 8779ade into main Aug 8, 2023
2 checks passed
@pjechris pjechris deleted the feat/observer-enqueue branch August 8, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Code that add significant changes tech
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant