Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech(observer): Use a registry to register observers #53

Merged
merged 14 commits into from
Jul 28, 2023

Conversation

pjechris
Copy link
Owner

⚽️ Description

This is a first step in collapsing observe changes by introducing a central type to handle them: ObserverRegistry.

On long term this should allow to better manage observations including collapsing like just said.

For now it does nothing more than what was done before.

Related to #48

🔨 Implementation details

  • Replace EntityObserver/AliasObserver internal implementations with ObserverRegistry
  • Trigger ObserverRegistry every time a node value changes
  • Added API to collapse notifications. But for now stick to a postNotification for every change.

@pjechris pjechris added the tech label Jul 28, 2023
@pjechris pjechris merged commit 5a87c9e into main Jul 28, 2023
2 checks passed
@pjechris pjechris deleted the tech/observer-registry branch July 28, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant