[Parse incomplete chunks 2/9] Add chunk type annotations, record gap sizes and filler allocations #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benkilimnik
force-pushed
the
g3
branch
5 times, most recently
from
14c685d
to
148724e
Compare
… instruction limit Signed-off-by: Benjamin Kilimnik <[email protected]>
etep
reviewed
Dec 7, 2023
src/stirling/source_connectors/socket_tracer/bcc_bpf_intf/socket_trace.hpp
Show resolved
Hide resolved
Signed-off-by: Benjamin Kilimnik <[email protected]>
|
@etep Could you give an approval if you think this is good to go @benkilimnik If you've done additional testing to ensure that this works (eg. on kernels older than 5.1 and kernels newer than 5.1), could you add it to the Test Plan in the PR description. If we haven't done that, I think it would be good to ensure that things work end to end, when we change bpf code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds metadata to
socket_data_event_tto keep track of gaps from bpf along with the number of bytes we miss. This metadata will be fed to prometheus in a future PR to keep track of the prevalence and distribution of gaps on a per protocol basis. More details in #1755.Type of change: /kind feature
Test Plan: Existing targets (including qemu bpf tests for kernel versions < 5.1 and > 5.1). Skaffolded to cluster running kernel > 5.1.