Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds property model #18

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Adds property model #18

merged 2 commits into from
Feb 10, 2024

Conversation

lellky
Copy link
Contributor

@lellky lellky commented Jan 14, 2024

I got a list of models from Flexit. It is really simple to extract the model from the serial number (the first six digits represents the model, the last six digits is just a consecutive number/serial number)

This is just a proposal.

The list with models are translated in Swedish, Norwegian, English and Finnish. If we want to translate the models that code should probably live in Home Assistant core.

Example output:

Device Name: HvacFnct21y_A
Serial Number: 800130-002967
Device Model: Air handling unit Nordic S4 RER
Outside air temp.: -1.4 °C
Supply air temp.: 17.9 °C
Extract air temp.: 20.0 °C
Exhaust air temp.: 2.9 °C
Room air temp.: 15.1 °C
Room 1 humidity: 0.0%
Room 2 humidity: 0.0%
Room 3 humidity: 0.0%
Comfort button state: True
Operation mode: 3
Ventilation mode: 3
Air temp. setpoint Away: 18.0 °C
Air temp. setpoint Home: 19.0 °C
Fireplace duration remaining: 10 minutes
Rapid ventilation duration remaining: 10 minutes
Supply air fan control signal: 74%
Supply air fan RPM: 2824
Exhaust air fan control signal: 70%
Exhaust air fan RPM: 2652
Electric heater enabled: True
Electric heater nominal power: 0.800000011920929 kW
Electric heater power consumption: 0.14538198709487915 kW
Fan setpoint - supply air Home: 74%
Fan setpoint - supply air Away: 42%
Fan setpoint - supply air High: 100%
Fan setpoint - supply air Cooker: 50%
Fan setpoint - supply air Fireplace: 90%
Fan setpoint - extract air Home: 70%
Fan setpoint - extract air Away: 40%
Fan setpoint - extract air High: 100%
Fan setpoint - extract air Cooker: 50%
Fan setpoint - extract air Fireplace: 50%
Air filter operating time: 8712.0 hours
Air filter exchange interval: 8784.0 days
Air filter polluted: False
Heat-exchanger efficiency: 80%
Heat-exchanger speed: 100%

@lellky lellky force-pushed the lellky/device-model branch from 3a726c9 to 053beef Compare January 15, 2024 09:22
@lellky
Copy link
Contributor Author

lellky commented Jan 15, 2024

I removed the part with "Air handling unit". And that is good, because now we wont need to translate the model name. This should be ready to merge if you agree the code looks good.

@lellky
Copy link
Contributor Author

lellky commented Jan 15, 2024

Actually, I think I was too fast. We should probably remove "Nordic" from the model name as well. Then the device could be named "Flexit Nordic" in Home Assistant and the model would be only "S4 REL" for example.

@lellky
Copy link
Contributor Author

lellky commented Jan 15, 2024 •
edited
Loading

I might have been to fast again... I think it is very important we get the naming right.

The integration in Home Assistant is called Flexit (flexit_bacnet)
The name of the device should then be either "Flexit Nordic" or just "Nordic"
The model of the device should then be only "S4 REL"

What I want is for a climate entity to be called (in HA): climate.flexit_nordic_s4_rel or climate.nordic_s4_rel and then a temperature sensor would be sensor.flexit_nordic_s4_rel_room_tempterature or sensor.nordic_s4_rel_room_temperature. The latter example would probably be better, since I think I read in the documentation somewhere that one should not repeat the name from the domain or something.

What do you think?

@piotrbulinski piotrbulinski merged commit 23b3ebe into piotrbulinski:main Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrbulinski piotrbulinski piotrbulinski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lellky @piotrbulinski