Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build:add codecov.yml #9618

Merged
merged 9 commits into from
Mar 8, 2019
Merged

build:add codecov.yml #9618

merged 9 commits into from
Mar 8, 2019

Conversation

xiekeyi98
Copy link
Contributor

What problem does this PR solve?

Add codecov.yml.

Tests

  • No code

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #9618 into master will increase coverage by 0.0804%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master      #9618        +/-   ##
================================================
+ Coverage   67.3268%   67.4073%   +0.0804%     
================================================
  Files           376        374         -2     
  Lines         79019      78895       -124     
================================================
- Hits          53201      53181        -20     
+ Misses        21064      20963       -101     
+ Partials       4754       4751         -3

@xiekeyi98 xiekeyi98 changed the title [WIP][DNM]build:add codecov.yml build:add codecov.yml Mar 8, 2019
@xiekeyi98
Copy link
Contributor Author

Sorry for some of my actions that caused a problem.

I have upgraded the CodeCov and now it works more strictly than before. (For example, in this PR:#9617 if what we commit has been covered less than the project"s average, CodeCov rejects to this merge.)

I think this is not what we expected.
I filed this PR can temporarily solve this problem by stopping to check the patch and allowing the coverage to drop by 0.2%.

Please Review this PR at first because this PR may block someone"s work.

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 8, 2019
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xiekeyi98 xiekeyi98 merged commit cb7a624 into pingcap:master Mar 8, 2019
@xiekeyi98 xiekeyi98 deleted the codeCov branch March 8, 2019 15:28
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
kennytm added a commit to pingcap/parser that referenced this pull request Dec 19, 2019
kennytm added a commit to pingcap/parser that referenced this pull request Dec 19, 2019
kennytm added a commit to pingcap/parser that referenced this pull request Dec 23, 2019
* terror: replace sirupsen/logrus by pingcap/log

also fixed test failure on Windows

* circle.yml: restrict test parallelism in integration tests

also, stop verifying parser.go and code format in the integration tests...
those steps are redundant.

* codecov: add codecov.yml, based on pingcap/tidb#9618

Co-authored-by: tiancaiamao <[email protected]>
tiancaiamao added a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
* terror: replace sirupsen/logrus by pingcap/log

also fixed test failure on Windows

* circle.yml: restrict test parallelism in integration tests

also, stop verifying parser.go and code format in the integration tests...
those steps are redundant.

* codecov: add codecov.yml, based on pingcap/tidb#9618

Co-authored-by: tiancaiamao <[email protected]>
xhebox pushed a commit to xhebox/tidb that referenced this pull request Oct 8, 2021
* terror: replace sirupsen/logrus by pingcap/log

also fixed test failure on Windows

* circle.yml: restrict test parallelism in integration tests

also, stop verifying parser.go and code format in the integration tests...
those steps are redundant.

* codecov: add codecov.yml, based on pingcap#9618

Co-authored-by: tiancaiamao <[email protected]>
ti-chi-bot pushed a commit that referenced this pull request Oct 9, 2021
* terror: replace sirupsen/logrus by pingcap/log

also fixed test failure on Windows

* circle.yml: restrict test parallelism in integration tests

also, stop verifying parser.go and code format in the integration tests...
those steps are redundant.

* codecov: add codecov.yml, based on #9618

Co-authored-by: tiancaiamao <[email protected]>
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
* terror: replace sirupsen/logrus by pingcap/log

also fixed test failure on Windows

* circle.yml: restrict test parallelism in integration tests

also, stop verifying parser.go and code format in the integration tests...
those steps are redundant.

* codecov: add codecov.yml, based on pingcap/tidb#9618

Co-authored-by: tiancaiamao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants