-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: upgrade go1.23.2 | tidb-test=pr/2411 #51126
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #51126 /- ##
================================================
Coverage 73.4286% 76.0917% 2.6631%
================================================
Files 1624 1648 24
Lines 448121 458963 10842
================================================
Hits 329049 349233 20184
Misses 98915 88042 -10873
- Partials 20157 21688 1531
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
1 similar comment
/retest |
15ab739
to
339d46d
Compare
f5577d4
to
cca379b
Compare
a3f67d4
to
a565307
Compare
/hold Waiting for the evaluation confirmation of @yudongusa and @bb7133 . |
/unhold wait for CI all green |
e489e7f
to
3637d26
Compare
/retest |
2 similar comments
/retest |
/retest |
/test all |
/retest |
/test all |
Signed-off-by: Weizhen Wang <[email protected]>
/test all |
/retest |
2 similar comments
/retest |
/retest |
Signed-off-by: Weizhen Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dveeden, GMHDBJD, lance6716, tangenta, tiancaiamao, winoros, XuHuaiyu, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
@hawkingrei: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #50765
#55480
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.