Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade go1.23.2 | tidb-test=pr/2411 #51126

Merged
merged 26 commits into from
Oct 9, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Feb 18, 2024

What problem does this PR solve?

Issue Number: close #50765

#55480

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2024
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: Patch coverage is 78.47534% with 48 lines in your changes missing coverage. Please review.

Project coverage is 76.0917%. Comparing base (9d2227d) to head (fba5105).
Report is 18 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51126         /-   ##
================================================
  Coverage   73.4286%   76.0917%    2.6631%     
================================================
  Files          1624       1648         24     
  Lines        448121     458963      10842     
================================================
  Hits         329049     349233      20184     
  Misses        98915      88042     -10873     
- Partials      20157      21688       1531     
Flag Coverage Δ
integration 51.9515% <48.2926%> (?)
unit 72.5717% <73.9910%> ( 0.0606%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (ø)
parser ∅ <ø> (∅)
br 63.8927% <100.0000%> ( 18.3666%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Feb 18, 2024
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2024
@hawkingrei hawkingrei force-pushed the go1220bazel branch 3 times, most recently from f5577d4 to cca379b Compare March 5, 2024 02:23
@hawkingrei hawkingrei changed the title *: upgrade go1.22.0 *: upgrade go1.22.1 Mar 6, 2024
@hawkingrei hawkingrei force-pushed the go1220bazel branch 2 times, most recently from a3f67d4 to a565307 Compare March 13, 2024 01:46
@purelind
Copy link
Contributor

/hold

Waiting for the evaluation confirmation of @yudongusa and @bb7133 .

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2024
@hawkingrei
Copy link
Member Author

hawkingrei commented Mar 13, 2024

/unhold

wait for CI all green

@hawkingrei hawkingrei removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2024
@hawkingrei hawkingrei force-pushed the go1220bazel branch 2 times, most recently from e489e7f to 3637d26 Compare March 28, 2024 02:59
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2024
@hawkingrei hawkingrei changed the title *: upgrade go1.22.1 *: upgrade go1.22.2 Apr 6, 2024
@ti-chi-bot ti-chi-bot bot added the approved label Oct 8, 2024
@hawkingrei
Copy link
Member Author

/retest

2 similar comments
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test all

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test all

Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
Copy link
Member Author

/test all

@hawkingrei
Copy link
Member Author

/retest

2 similar comments
@purelind
Copy link
Contributor

purelind commented Oct 9, 2024

/retest

@hawkingrei
Copy link
Member Author

/retest

Signed-off-by: Weizhen Wang <[email protected]>
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dveeden, GMHDBJD, lance6716, tangenta, tiancaiamao, winoros, XuHuaiyu, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei hawkingrei changed the title *: upgrade go1.23.2 *: upgrade go1.23.2 | tidb-test=pr/2411 Oct 9, 2024
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

Copy link

tiprow bot commented Oct 9, 2024

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test fba5105 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 8c4bab1 into pingcap:master Oct 9, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/dumpling This is related to Dumpling of TiDB. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade go 1.22
10 participants