Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privileges: Fix panic when using skip-grant-table #27558

Merged
merged 1 commit into from
Aug 24, 2021
Merged

privileges: Fix panic when using skip-grant-table #27558

merged 1 commit into from
Aug 24, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Aug 24, 2021

What problem does this PR solve?

Issue Number: close #27555

Problem Summary: tidb-server panics with skip-grant-tables enabled

What is changed and how it works?

Check for SkipWithGrant when getting the auth plugin for a user.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

None

This doesn't yet have good unittest(s) or integration test(s), I'm planning to spend some time on trying to find a good way to do this.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 24, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 24, 2021
@dveeden
Copy link
Contributor Author

dveeden commented Aug 24, 2021

Note that testSessionSerialSuite.TestSkipWithGrant isn't catching this.

$ go test -check.f TestSkipWithGrant 2>&1 | grep PASS
PASS: session_test.go:1055: testSessionSerialSuite.TestSkipWithGrant	0.030s
PASS

@morgo morgo self-requested a review August 24, 2021 16:01
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 24, 2021
@morgo
Copy link
Contributor

morgo commented Aug 24, 2021

@dveeden I assume this needs a cherry pick to 5.2?

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 24, 2021
@bb7133
Copy link
Member

bb7133 commented Aug 24, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0857c57

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 24, 2021
@bb7133 bb7133 added needs-cherry-pick-release-5.2 and removed status/can-merge Indicates a PR has been approved by a committer. labels Aug 24, 2021
@dveeden
Copy link
Contributor Author

dveeden commented Aug 24, 2021

@dveeden I assume this needs a cherry pick to 5.2?

Yes

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 24, 2021
@ti-chi-bot ti-chi-bot merged commit 74fd4f1 into pingcap:master Aug 24, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 24, 2021
@dveeden @ti-srebot
cherry pick pingcap#27558 to release-5.2
159860b 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 24, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27559

ti-chi-bot pushed a commit that referenced this pull request Aug 25, 2021
@ti-srebot
privileges: Fix panic when using skip-grant-table (#27558) (#27559)
9d798d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@morgo morgo morgo approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.2 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic happens when TiDB starts with 'skip-grant-table'
5 participants
@dveeden @ti-chi-bot @morgo @bb7133 @ti-srebot