terror: replace sirupsen/logrus by pingcap/log #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fixed test failure on Windows
ghost
requested review from
also, stop verifying parser.go and code format in the integration tests... those steps are redundant.
Codecov Report
@@ Coverage Diff @@
## master #693 /- ##
=======================================
Coverage 79.86% 79.86%
=======================================
Files 37 37
Lines 13654 13654
=======================================
Hits 10905 10905
Misses 2103 2103
Partials 646 646 |
kennytm
force-pushed
the
kennytm/misc-fixes
branch
from
f5d213f to
b37eacb
Compare
|
PTAL @tiancaiamao |
|
LGTM |
tiancaiamao
approved these changes
Dec 23, 2019
|
(CLA broken ) |
tiancaiamao
added a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
* terror: replace sirupsen/logrus by pingcap/log also fixed test failure on Windows * circle.yml: restrict test parallelism in integration tests also, stop verifying parser.go and code format in the integration tests... those steps are redundant. * codecov: add codecov.yml, based on pingcap/tidb#9618 Co-authored-by: tiancaiamao <[email protected]>
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
* terror: replace sirupsen/logrus by pingcap/log also fixed test failure on Windows * circle.yml: restrict test parallelism in integration tests also, stop verifying parser.go and code format in the integration tests... those steps are redundant. * codecov: add codecov.yml, based on pingcap/tidb#9618 Co-authored-by: tiancaiamao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Apply pingcap/tidb#13459 on this repository.
Fixed some unit test failures on Windows.
What is changed and how it works?
Replaced the only use of
sirupsen/logrusinterrorbypingcap/log.Check List
Tests
Code changes
terror.MustNil,terror.Callandterror.Log) now write logs to the default logger ofpingcap/loginstead oflogrus.Side effects
Related changes