Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failpoint can not use a constant-string as marker function name #35

Closed
spongedu opened this issue Jun 4, 2019 · 4 comments
Closed

failpoint can not use a constant-string as marker function name #35

spongedu opened this issue Jun 4, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@spongedu
Copy link
Contributor

spongedu commented Jun 4, 2019

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.
    failpoint fail to rewrite the following circumstance:
package main

import (

    "github.com/pingcap/failpoint"
)
const (
   Marker = "failpoint-name"
)
func F1(name string) string {

    failpoint.Inject(Marker, nil)

    return "hello "   name
}
  1. What did you expect to see?
    This file can be correctly rewritten by failpoint-ctl tool

  2. What did you see instead?
    rewrite failed.

/bin/sh: Rewrite: command not found
make: *** [failpoint-enable] Error 127
  1. Versions of the failpoint

    • failpoint-ctl version (run failpoint-ctl -V):

ReleaseVersion bf45ab2
BuildTS 2019-05-15 09:48:44
GitHash bf45ab2
GitBranch master
GoVersion go version go1.12 darwin/amd64

@spongedu spongedu added the bug Something isn't working label Jun 4, 2019
@spongedu
Copy link
Contributor Author

spongedu commented Jun 4, 2019

@lonng as we've discussed. Open an issue to track this.

@lonng
Copy link
Contributor

lonng commented Jun 4, 2019

Thanks for your report.

@amyangfei
Copy link
Contributor

fixed in #46

@spongedu
Copy link
Contributor Author

Wow! Great! thanks @amyangfei @hanfei1991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants