Use StdinLock instead of BufReader

StdinLock already implements BufRead, using BufReader will only increase the number of memcpy calls since it re-buffers.
pickfire · Feb 18, 2021 · baf1ec4 · baf1ec4
1 parent c22f919
commit baf1ec4
Show file tree

Hide file tree

Showing 9 changed files with 27 additions and 18 deletions.
diff --git a/src/bin/cbor2json.rs b/src/bin/cbor2json.rs
@@ -1,7  1,8 @@
-use std::io::{self, BufReader, BufWriter};
 use std::io::{self, BufWriter};
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
-    let reader = BufReader::new(io::stdin());
     let reader = io::stdin();
     let reader = reader.lock();
     let writer = BufWriter::new(io::stdout());
 
     let mut deserializer = serde_cbor::Deserializer::from_reader(reader);

diff --git a/src/bin/cbor2toml.rs b/src/bin/cbor2toml.rs
@@ -1,7  1,8 @@
-use std::io::{self, BufReader, BufWriter, Write};
 use std::io::{self, BufWriter, Write};
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
-    let reader = BufReader::new(io::stdin());
     let reader = io::stdin();
     let reader = reader.lock();
     let mut writer = BufWriter::new(io::stdout());
 
     let mut buffer = String::new();

diff --git a/src/bin/cbor2yaml.rs b/src/bin/cbor2yaml.rs
@@ -1,7  1,8 @@
-use std::io::{self, BufReader, BufWriter};
 use std::io::{self, BufWriter};
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
-    let reader = BufReader::new(io::stdin());
     let reader = io::stdin();
     let reader = reader.lock();
     let writer = BufWriter::new(io::stdout());
 
     let mut deserializer = serde_cbor::Deserializer::from_reader(reader);

diff --git a/src/bin/json2cbor.rs b/src/bin/json2cbor.rs
@@ -1,7  1,8 @@
-use std::io::{self, BufReader, BufWriter};
 use std::io::{self, BufWriter};
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
-    let reader = BufReader::new(io::stdin());
     let reader = io::stdin();
     let reader = reader.lock();
     let writer = BufWriter::new(io::stdout());
 
     let writer = serde_cbor::ser::IoWrite::new(writer);

diff --git a/src/bin/json2toml.rs b/src/bin/json2toml.rs
@@ -1,7  1,8 @@
-use std::io::{self, BufReader, BufWriter, Write};
 use std::io::{self, BufWriter, Write};
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
-    let reader = BufReader::new(io::stdin());
     let reader = io::stdin();
     let reader = reader.lock();
     let mut writer = BufWriter::new(io::stdout());
 
     let mut buffer = String::new();

diff --git a/src/bin/json2yaml.rs b/src/bin/json2yaml.rs
@@ -1,7  1,8 @@
-use std::io::{self, BufReader, BufWriter};
 use std::io::{self, BufWriter};
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
-    let reader = BufReader::new(io::stdin());
     let reader = io::stdin();
     let reader = reader.lock();
     let writer = BufWriter::new(io::stdout());
 
     let mut deserializer = serde_json::Deserializer::from_reader(reader);

diff --git a/src/bin/yaml2cbor.rs b/src/bin/yaml2cbor.rs
@@ -1,7  1,8 @@
-use std::io::{self, BufReader, BufWriter};
 use std::io::{self, BufWriter};
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
-    let reader = BufReader::new(io::stdin());
     let reader = io::stdin();
     let reader = reader.lock();
     let writer = BufWriter::new(io::stdout());
 
     let writer = serde_cbor::ser::IoWrite::new(writer);

diff --git a/src/bin/yaml2json.rs b/src/bin/yaml2json.rs
@@ -1,7  1,8 @@
-use std::io::{self, BufReader, BufWriter};
 use std::io::{self, BufWriter};
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
-    let reader = BufReader::new(io::stdin());
     let reader = io::stdin();
     let reader = reader.lock();
     let writer = BufWriter::new(io::stdout());
 
     let deserializer = serde_yaml::Deserializer::from_reader(reader);

diff --git a/src/bin/yaml2toml.rs b/src/bin/yaml2toml.rs
@@ -1,7  1,8 @@
-use std::io::{self, BufReader, BufWriter, Write};
 use std::io::{self, BufWriter, Write};
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
-    let reader = BufReader::new(io::stdin());
     let reader = io::stdin();
     let reader = reader.lock();
     let mut writer = BufWriter::new(io::stdout());
 
     let mut buffer = String::new();