Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temperature settings forgotten after #3139 #3151

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Remove temperature settings forgotten after #3139 #3151

merged 1 commit into from
Sep 29, 2024

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

Please see title.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign rdwebdesign requested a review from a team September 27, 2024 16:00
yubiuser
yubiuser approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of the FTL stuff could still be removed

2024-09-28_13-35

@rdwebdesign
Copy link
Member Author

Do you mean to remove these options from FTL or do you mean remove from "All Settings" page?

If you remove from FTL, they will be automatically removed from "All Settings" page (this page is dynamic).

@yubiuser
Copy link
Member

From FTL... Without removing the things necessary for PADD.

@rdwebdesign
Copy link
Member Author

If we remove these options from FTL / API, how will PADD users change the temperature unit?

@rdwebdesign rdwebdesign merged commit ae728a1 into development Sep 29, 2024
11 checks passed
@rdwebdesign rdwebdesign deleted the remove_temp_settings branch September 29, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yubiuser yubiuser yubiuser approved these changes

@DL6ER DL6ER DL6ER approved these changes

Assignees
No one assigned
Labels
Pi-hole v6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rdwebdesign @yubiuser @DL6ER