Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of improvements #1973

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from
Open

Backport of improvements #1973

wants to merge 36 commits into from

Conversation

iliaal
Copy link
Contributor

@iliaal iliaal commented May 31, 2021

  • Introduced size limit for compression
  • Introduced min compression ratio
  • Allow by-pass of igbinary for string literals
  • Allow clone of redis object

iliaal and others added 30 commits June 13, 2020 18:28
Presently PhpRedis will segfault if users attempt to clone either the
Redis or RedisCluster objects.

We plan on investigating proper clone support in future releases, but
for now just diable the handlers.
Without this, performing a HMGET call fails to decompress the data before
returning it to php.
ZSTD uses two defined error numbers to inform the caller when the
compressed data is invalid (e.g. wrong magic number) or the size is
unknown.

We should always know the size so abort if ZSTD returns either to us.

Fixes: phpredis#1936
Rework the session locking unit tests to be less reliant on arbitrary
sleep calls which can be very troublesome when running in Travis and
especially when running in Travis under valgrind.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants