Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhpRedis 6.1.0RC1 #2531

Open
michael-grunder opened this issue Jul 31, 2024 · 3 comments
Open

PhpRedis 6.1.0RC1 #2531

michael-grunder opened this issue Jul 31, 2024 · 3 comments

Comments

@michael-grunder
Copy link
Member

michael-grunder commented Jul 31, 2024 •
edited
Loading

I've created PR #2530 for PhpRedis 6.1.0RC1.

Just creating this issue so people can comment if they see any issues.

The only changes that could cause any heartburn are some stub changes and two timeout-related fixes.
@remicollet
Copy link
Collaborator

remicollet commented Aug 5, 2024 •
edited
Loading

PHP < 7.4 have been removed from CI

TestSuite is no more compatible with old PHP

Ex, with 7.3

Parse error: syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in /builddir/build/BUILD/php-pecl-redis6-6.1.0~RC1/redis-6.1.0RC1/tests/TestSuite.php on line 10

I think we should choose between

  • fixing TestSuite, but CI needed
  • raising the minimal supported version to 7.4 (I'm 1 for this)

P.S. also see PR #2532

michael-grunder added a commit that referenced this issue Aug 5, 2024
@michael-grunder
Raise minimum supported PHP version to 7.4
b5c3f8d 
See #2531
@michael-grunder michael-grunder mentioned this issue Aug 5, 2024
Merged
michael-grunder added a commit that referenced this issue Aug 5, 2024
@michael-grunder
Raise minimum supported PHP version to 7.4
8b51942 
See #2531
@lerminou
Copy link

lerminou commented Sep 2, 2024

Hi, do you have any ETA for the choice to remove old php and the release date?

@michael-grunder
Copy link
Member Author

Release this week. Sorry for the delay something non work-related came up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@remicollet @michael-grunder @lerminou