Fix #556 - Implementing and refactoring the KILL statement parser #565
Conversation
iifawzi
force-pushed
the
fix/556-parsing-kill-statements
branch
3 times, most recently
from
558b556
to
afe9173
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.10.x #565 /- ##
============================================
Coverage 96.79% 96.81% 0.02%
- Complexity 2259 2294 35
============================================
Files 69 70 1
Lines 5174 5248 74
============================================
Hits 5008 5081 73
- Misses 166 167 1 ☔ View full report in Codecov by Sentry. |
iifawzi
force-pushed
the
fix/556-parsing-kill-statements
branch
from
bb3bbe0
to
1630359
Compare
|
DS_Store are MacOS files so they are not relevant to this project. They should not be ignored at all. You can ignore them locally on your machine. |
|
it's easier for future contributors to have it ignored by the repo as we do with .idea, vim, and backup files. |
I checked, and yes I think the actual consensus is to remove them locally. We do not have it in any repo. Ref: phpmyadmin/phpmyadmin#15903 (comment) |
Signed-off-by: Fawzi Abdulfattah <[email protected]>
iifawzi
force-pushed
the
fix/556-parsing-kill-statements
branch
from
65dd968
to
c5033af
Compare
Co-authored-by: Maurício Meneghini Fauth <[email protected]>
Signed-off-by: Fawzi Abdulfattah <[email protected]>
Co-authored-by: William Desportes <[email protected]>
williamdes
changed the title
Hey!
This PR extends support of KILL statements. completing #557 and fixing 556
Fixes #556