Fix query flags for lower-case functions #564
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoonE
force-pushed
the
fix-count-query-flags-lower-case
branch
from
32cd6d0
to
a4f7166
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.9.x #564 /- ##
=========================================
Coverage 96.79% 96.79%
- Complexity 2257 2258 1
=========================================
Files 69 69
Lines 5172 5175 3
=========================================
Hits 5006 5009 3
Misses 166 166 ☔ View full report in Codecov by Sentry. |
iifawzi
approved these changes
Jul 4, 2024
|
Not sure why benchmarks are not passing |
|
it's unexpectedly faster? What these numbers are based on? |
Oh, on what I had when I wrote the bench. Maybe we can update to quicker then |
Signed-off-by: Maximilian Krög <[email protected]>
MoonE
force-pushed
the
fix-count-query-flags-lower-case
branch
from
a4f7166
to
35ca80b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See phpmyadmin/phpmyadmin#16869
is_funcandis_countwere only set when the function is in all upper case.