Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project manifest #356

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Add project manifest #356

merged 1 commit into from
Apr 4, 2023

Conversation

snk4tr
Copy link
Contributor

@snk4tr snk4tr commented Apr 4, 2023

Closes #355

Proposed Changes

  • Add project manifesto
  • Make it easy to understand and not too fancy

What do you guys think? Is there something to add?

@snk4tr snk4tr self-assigned this Apr 4, 2023
@snk4tr snk4tr requested review from zakajd and denproc April 4, 2023 19:51
@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@snk4tr snk4tr added the documentation Improvements or additions to documentation label Apr 4, 2023
@snk4tr snk4tr changed the title add manifest Add project manifest Apr 4, 2023
Copy link
Collaborator

@zakajd zakajd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #356 (d16f83b) into master (09aad9e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #356    /-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          34       34           
  Lines        2491     2491           
=======================================
  Hits         2292     2292           
  Misses        199      199           
Flag Coverage Δ
unittests 92.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@denproc denproc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denproc denproc merged commit 8edc780 into master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add project manifesto
3 participants