Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for feature metrics #276

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Fix docs for feature metrics #276

merged 1 commit into from
Nov 19, 2021

Conversation

zakajd
Copy link
Collaborator

@zakajd zakajd commented Nov 4, 2021

Closes #275

Proposed Changes

  • Update docs to have proper usage examples.

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zakajd zakajd requested a review from denproc November 4, 2021 09:22
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #276 (e80baf0) into master (147ec75) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276       /-   ##
==========================================
- Coverage   93.34%   93.25%   -0.09%     
==========================================
  Files          33       33              
  Lines        2283     2283              
==========================================
- Hits         2131     2129       -2     
- Misses        152      154        2     
Flag Coverage Δ
unittests 93.25% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
piq/fid.py 91.22% <ø> (ø)
piq/gs.py 90.10% <ø> (-2.20%) ⬇️
piq/isc.py 90.90% <ø> (ø)
piq/kid.py 88.77% <ø> (ø)
piq/msid.py 77.19% <ø> (ø)
piq/pr.py 100.00% <ø> (ø)

Copy link
Collaborator

@denproc denproc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denproc denproc merged commit a7d6bdc into master Nov 19, 2021
@denproc denproc deleted the docs/fix_feature_metrics branch November 19, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssertionError: Expected number of dimensions to be 2, got 4
2 participants