Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flash without ID not being closeable #5602

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix flash without ID not being closeable #5602

merged 1 commit into from
Oct 18, 2023

Conversation

jorams
Copy link
Contributor

@jorams jorams commented Oct 15, 2023

If no id was specified (like in flash_group) it defaulted to nil. The call to assign_new (#5542) did nothing because a default of nil had been assigned already.

@dinocosta dinocosta mentioned this pull request Oct 17, 2023
Closed
@Gazler Gazler merged commit 26e2e5e into phoenixframework:main Oct 18, 2023
@Gazler
Copy link
Member

Gazler commented Oct 18, 2023

Great spot, thanks! <3

@kyleboe kyleboe mentioned this pull request Oct 25, 2023
Closed
@ivcosla ivcosla mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jorams @Gazler