Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress dialyzer pattern_match error #5446

Merged
merged 1 commit into from
May 24, 2023
Merged

Suppress dialyzer pattern_match error #5446

merged 1 commit into from
May 24, 2023

Conversation

mpotra
Copy link
Contributor

@mpotra mpotra commented Apr 30, 2023

This PR suppresses a dialyzer error that shows up in projects depending on phoenix v1.7.2 (possibly brought in with v1.7.0)

Environment

  • Elixir version: Elixir 1.14.4 (compiled with Erlang/OTP 23)
  • Phoenix version (mix deps): 1.7.2
  • OS: Fedora 36
deps/phoenix/lib/phoenix/router.ex:514:pattern_match
The pattern can never match the type.

Pattern:
:error

Type:

  {%{
     :conn => nil,
     :log => :debug,
     :path_params => map(),
     :pipe_through => [any(), ...],
     :plug => ArgonApi.AuthController | ArgonApi.NotFound,
     :plug_opts => :index | [],
     :route => <<_::8, _::size(16)>>
   }, (map(), map() -> map()), (map() -> map()),
   {ArgonApi.AuthController, :index} | {Phoenix.Router.Route, {_, _, _}}}

@josevalim josevalim merged commit 552247f into phoenixframework:main May 24, 2023
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpotra @josevalim