Adding info log if they have http/https set but not server: true set #5362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Mar 15, 2023
lib/phoenix/endpoint/supervisor.ex
Outdated
| @@ -127,6 127,11 @@ defmodule Phoenix.Endpoint.Supervisor do | |||
| adapter = config[:adapter] || Phoenix.Endpoint.Cowboy2Adapter | |||
| adapter.child_specs(mod, config) | |||
| else | |||
| if config[:http] || config[:https] do | |||
There was a problem hiding this comment.
I would probably use a cond to avoid nesting.
josevalim
reviewed
Mar 15, 2023
Co-authored-by: José Valim <[email protected]>
|
@josevalim <3 thanks |
josevalim
approved these changes
Mar 16, 2023
|
❤️❤️❤️🐥🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user misconfigures their app to not set
server: trueon the endpoint with releases the app just hangs and has no reason to log anything by default.See dwyl/phoenix-liveview-chat-example#111 (comment) this should warn them if they have HTTP/HTTPS set but not server: true.