Only log when running in release. Closes #5372

phoenixframework · Mar 22, 2023 · 78f30a6 · 78f30a6 · clarkware · Mar 22, 2023
1 parent b63dcf0
commit 78f30a6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/phoenix/endpoint/supervisor.ex b/lib/phoenix/endpoint/supervisor.ex
@@ -141,9  141,11 @@ defmodule Phoenix.Endpoint.Supervisor do
         adapter.child_specs(mod, config)
 
       config[:http] || config[:https] ->
-        Logger.info(
-          "Configuration :server was not enabled for #{inspect(mod)}, http/https services won't start"
-        )
         if System.get_env("RELEASE_NAME") do
           Logger.info(
             "Configuration :server was not enabled for #{inspect(mod)}, http/https services won't start"
           )
         end
 
         []
 

diff --git a/test/phoenix/endpoint/supervisor_test.exs b/test/phoenix/endpoint/supervisor_test.exs
@@ -91,8  91,10 @@ defmodule Phoenix.Endpoint.SupervisorTest do
   end
 
   import ExUnit.CaptureLog
-  test "logs info if :http or :https configuration is set but not :server" do
   test "logs info if :http or :https configuration is set but not :server when running in release" do
     Logger.configure(level: :info)
     # simulate running inside release
     System.put_env("RELEASE_NAME", "phoenix-test")
     Application.put_env(:phoenix, ServerEndpoint, [server: false, http: [], https: []])
     assert capture_log(fn ->
       {:ok, {_, _children}} = Supervisor.init({:phoenix, ServerEndpoint, []})