Skip to content

Commit

Permalink
Release 1.7.2
Browse files Browse the repository at this point in the history
  • Loading branch information
chrismccord committed Mar 20, 2023
1 parent 1d45340 commit 1d88747
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 17 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 46,10 @@ styled with Tailwind CSS by default. You can opt-out of Tailwind CSS with the `-
flag (the Tailwind CSS classes are kept in the generated components as reference for
future styling).

## 1.7.2-dev
## 1.7.2 (2023-03-20)

### Enhancements
* [Endpoint] Add socket draining for batched and orchestrated Channel/LiveView socket shutdown
* [code reloader] Improve the compilation error page to remove horizontal scrolling and include all warnings and errors from compilation
* [phx.new] Support the `--no-tailwind` and `--no-esbuild` flags
* [phx.new] Move heroicons to assets/vendor
Expand Down
4 changes: 2 additions & 2 deletions assets/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion assets/package.json
Original file line number Diff line number Diff line change
@@ -1,6 1,6 @@
{
"name": "phoenix",
"version": "1.7.1",
"version": "1.7.2",
"description": "The official JavaScript client for the Phoenix web framework.",
"license": "MIT",
"main": "./assets/js/phoenix/index.js",
Expand Down
2 changes: 1 addition & 1 deletion installer/mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 6,7 @@ end
defmodule Phx.New.MixProject do
use Mix.Project

@version "1.7.1"
@version "1.7.2"
@scm_url "https://github.com/phoenixframework/phoenix"

# If the elixir requirement is updated, we need to update:
Expand Down
8 changes: 4 additions & 4 deletions installer/templates/phx_web/components/core_components.ex
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 47,7 @@ defmodule <%= @web_namespace %>.CoreComponents do
id={@id}
phx-mounted={@show && show_modal(@id)}
phx-remove={hide_modal(@id)}
phx-cancel={JS.exec(@on_cancel, "phx-remove")}
data-cancel={JS.exec(@on_cancel, "phx-remove")}
class="relative z-50 hidden"
>
<div id={"#{@id}-bg"} class="bg-zinc-50/90 fixed inset-0 transition-opacity" aria-hidden="true" />
Expand All @@ -63,14 63,14 @@ defmodule <%= @web_namespace %>.CoreComponents do
<div class="w-full max-w-3xl p-4 sm:p-6 lg:py-8">
<.focus_wrap
id={"#{@id}-container"}
phx-window-keydown={JS.exec("phx-cancel", to: "##{@id}")}
phx-window-keydown={JS.exec("data-cancel", to: "##{@id}")}
phx-key="escape"
phx-click-away={JS.exec("phx-cancel", to: "##{@id}")}
phx-click-away={JS.exec("data-cancel", to: "##{@id}")}
class="shadow-zinc-700/10 ring-zinc-700/10 relative hidden rounded-2xl bg-white p-14 shadow-lg ring-1 transition"
>
<div class="absolute top-6 right-5">
<button
phx-click={JS.exec("phx-cancel", to: "##{@id}")}
phx-click={JS.exec("data-cancel", to: "##{@id}")}
type="button"
class="-m-3 flex-none p-3 opacity-20 hover:opacity-40"
aria-label=<%= if @gettext do %>{gettext("close")}<% else %>"close"<% end %>
Expand Down
4 changes: 2 additions & 2 deletions lib/phoenix/endpoint.ex
Original file line number Diff line number Diff line change
Expand Up @@ -800,9 800,9 @@ defmodule Phoenix.Endpoint do
* `:batch_size` - How many clients to notify at once in a given batch.
Defaults to 10000.
* `:batch_interval` - The amount of time in miliseconds given for a
* `:batch_interval` - The amount of time in milliseconds given for a
batch to terminate. Defaults to 2000ms.
* `:shutdown` - The maximum amount of time in miliseconds allowed
* `:shutdown` - The maximum amount of time in milliseconds allowed
to drain all batches. Defaults to 30000ms.
For example, if you have 150k connections, the default values will
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 8,7 @@ defmodule Phoenix.MixProject do
end
end

@version "1.7.1"
@version "1.7.2"
@scm_url "https://github.com/phoenixframework/phoenix"

# If the elixir requirement is updated, we need to make the installer
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 1,6 @@
{
"name": "phoenix",
"version": "1.7.1",
"version": "1.7.2",
"description": "The official JavaScript client for the Phoenix web framework.",
"license": "MIT",
"module": "./priv/static/phoenix.mjs",
Expand Down
8 changes: 4 additions & 4 deletions priv/templates/phx.gen.live/core_components.ex
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 47,7 @@ defmodule <%= @web_namespace %>.CoreComponents do
id={@id}
phx-mounted={@show && show_modal(@id)}
phx-remove={hide_modal(@id)}
phx-cancel={JS.exec(@on_cancel, "phx-remove")}
data-cancel={JS.exec(@on_cancel, "phx-remove")}
class="relative z-50 hidden"
>
<div id={"#{@id}-bg"} class="bg-zinc-50/90 fixed inset-0 transition-opacity" aria-hidden="true" />
Expand All @@ -63,14 63,14 @@ defmodule <%= @web_namespace %>.CoreComponents do
<div class="w-full max-w-3xl p-4 sm:p-6 lg:py-8">
<.focus_wrap
id={"#{@id}-container"}
phx-window-keydown={JS.exec("phx-cancel", to: "##{@id}")}
phx-window-keydown={JS.exec("data-cancel", to: "##{@id}")}
phx-key="escape"
phx-click-away={JS.exec("phx-cancel", to: "##{@id}")}
phx-click-away={JS.exec("data-cancel", to: "##{@id}")}
class="shadow-zinc-700/10 ring-zinc-700/10 relative hidden rounded-2xl bg-white p-14 shadow-lg ring-1 transition"
>
<div class="absolute top-6 right-5">
<button
phx-click={JS.exec("phx-cancel", to: "##{@id}")}
phx-click={JS.exec("data-cancel", to: "##{@id}")}
type="button"
class="-m-3 flex-none p-3 opacity-20 hover:opacity-40"
aria-label=<%= if @gettext do %>{gettext("close")}<% else %>"close"<% end %>
Expand Down

0 comments on commit 1d88747

Please sign in to comment.