Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow kebab and snake case folders #364

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nimish-ks
Copy link
Member

🔍 Overview

This PR expands the range of possible folder and path names beyond alphanumeric name by adding support snake_case and kebab-case paths.

The new regex pattern:

const folder_name_pattern = /^[a-zA-Z0-9_-]*$/

💡 Proposed Changes

  • Updated the folder_name_pattern in NewFolderMenu

🖼️ Screenshots or Demo

image

📝 Release Notes

  • Enhanced path handling to support kebab-case and snake_case in folder and path names.
  • Users can now use paths like /backend/user-service/config or /frontend/user_profile/settings in their configurations.

✨ How to Test the Changes Locally

  1. Create folder names with - and _ in the Phase Console
  2. Fetch secrets via the CLI, API, SDKs etc.
  3. Test secret referencing

@nimish-ks nimish-ks changed the title feat: allow kebab and snake case folder names feat: allow kebab and snake case folders Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant