Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Please review the guidelines for contributing to this repository.
Issue number(s) that this pull request fixes
List of changes to the codebase in this pull request
DynamicBayesianNetwork
functionget_constant_bn
.get_constant_bn
already have the CPDs, removedadd_cpds
NOTE:
Code is not fully functional. The line
pgmpy/pgmpy/inference/dbn_inference.py
Line 70 in c720120
NodeView(('A_0', 'A_1', 'B_1', 'C_0', 'B_0', 'C_1', <DynamicNode(A, 0) at 0x22298476f08>, <DynamicNode(B, 0) at 0x2229847f0c8>, <DynamicNode(C, 0) at 0x2229847f108>))
As you can see, the three last nodes were already added. I don't know the reason they are represented differently.
The question is: should we change how the node is represented/compared or should we come back to
base.py
and think another solution other thanget_constant_bn