Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BayesianNetwork.fit method to DAG.fit #1784

Closed
ankurankan opened this issue Jun 18, 2024 · 0 comments · Fixed by #1839
Closed

Move BayesianNetwork.fit method to DAG.fit #1784

ankurankan opened this issue Jun 18, 2024 · 0 comments · Fixed by #1839

Comments

@ankurankan
Copy link
Member

As structure learning algorithms output either a pgmpy.base.PDAG or pgmpy.base.DAG object, to fit parameters to these models users currently need to convert them to a pgmpy.models.BayesianNetwork object. By moving the BayesianNetwork.fit method to DAG.fit, it would make the workflow simpler and more straightforward. As BayesianNetwork inherits DAG, there would be no change in the Bayesian Network API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant