Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut a release? #93

Closed
shuoli84 opened this issue Feb 17, 2023 · 7 comments
Closed

Cut a release? #93

shuoli84 opened this issue Feb 17, 2023 · 7 comments

Comments

@shuoli84
Copy link
Contributor

There are eight new commits since last release. Thanks in advance.

@james7132
Copy link
Collaborator

There is one thing I think needs to be addressed following #74: usize is dependent on the architecture and is used in the serde implementation. I"d like to get that sorted out before anything public is released.

@shuoli84
Copy link
Contributor Author

There is one thing I think needs to be addressed following #74: usize is dependent on the architecture and is used in the serde implementation. I"d like to get that sorted out before anything public is released.

I see. You mean the serialized data is incompatible before and after the u32 -> usize change, right?

@james7132
Copy link
Collaborator

That"s true, but I"m more concerned with portability of serialized data from one architecture to another.

@shuoli84
Copy link
Contributor Author

yes, need to create custom serialize mod which also makes endianness correct.

@shuoli84
Copy link
Contributor Author

Current implementation is not portable, maybe we should define the serialized format first. add an endian flag to the data, or serialize data to [u8]?

@shuoli84
Copy link
Contributor Author

@james7132 if this is a release blocker, how about hide the usize as a opt in feature?

@james7132
Copy link
Collaborator

0.5.0 has been published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants