Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-7 use compose plugin of docker #1949

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Apr 5, 2023

It's been some time since major Docker distributions adopted the docker "compose" plugin, which is mostly installed by default. Therefore, we'd benefit from using it instead of the "docker-compose" utility, which needs to be provisioned additionally.

PMM-7

Link to the Feature Build: SUBMODULES-0

It's been some time since major Docker distributions adopted the docker "compose" plugin, which is mostly installed by default. therefore, we'd benefit from migrating to using it instead of the "docker-compose" utility, which is not installed by default.
@ademidoff ademidoff requested a review from a team as a code owner April 5, 2023 11:32
@ademidoff ademidoff requested review from gen1us2k, rishat-ishbulatov, BupycHuk, artemgavrilov and recharte and removed request for a team April 5, 2023 11:32
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #1949 (c2b8427) into main (40facc9) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1949       /-   ##
==========================================
- Coverage   42.60%   42.56%   -0.04%     
==========================================
  Files         376      376              
  Lines       48638    48638              
==========================================
- Hits        19574    19557      -17     
- Misses      24564    24582       18     
  Partials     1810     1809       -1     
Flag Coverage Δ
admin 10.36% <ø> (-0.05%) ⬇️
agent 52.88% <ø> (-0.16%) ⬇️
managed 43.76% <ø> (ø)
vmproxy 70.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ademidoff ademidoff enabled auto-merge (squash) April 6, 2023 06:24
@ademidoff ademidoff disabled auto-merge April 6, 2023 08:31
@ademidoff ademidoff enabled auto-merge (squash) April 10, 2023 13:46
@ademidoff ademidoff disabled auto-merge April 10, 2023 13:46
@ademidoff ademidoff merged commit f7bf557 into main Apr 10, 2023
@ademidoff ademidoff deleted the PMM-7-user-compose-plugin-of-docker branch April 10, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants