PMM-10900: custom image and option to run pmm with external clickhouse #1314
Conversation
| @@ -2,28 2,40 @@ | |||
|
|
|||
| include Makefile.include | |||
|
|
|||
| ifeq ($(PROFILES),) | |||
| PROFILES := 'pmm' | |||
There was a problem hiding this comment.
by default run as it runs now
| hostname: ${CH_HOSTNAME:-ch} | ||
| ports: | ||
| - ${CH_PORT:-9500}:9500 | ||
| pmm-managed-server-ch: |
There was a problem hiding this comment.
ch and pmm-managed-server-ch will be used when develop runs container the following way:
PROFILES=pmm-ch make env-up
| - root-cache:/root/.cache | ||
|
|
||
| # PMM with external ClickHouse DB | ||
| ch: |
There was a problem hiding this comment.
use external ClickHouse (force AMD64), as DBaaS fails (in arm64 builds, amd64 works fine) with one that is running in container.
| release-dev: | ||
| go build -race -gcflags="all=-N -l" -v $(PMM_LD_FLAGS) -o $(PMM_RELEASE_PATH)/ ./cmd/... | ||
| @if [ $(ARCH) = "aarch64" ]; then\ | ||
| go build -gcflags="all=-N -l" -v $(PMM_LD_FLAGS) -o $(PMM_RELEASE_PATH)/ ./cmd/... |
There was a problem hiding this comment.
for ARM do not run with -race
-race causes crash building pmm-managed binaries
# github.com/percona/pmm/managed/cmd/pmm-managed
reflect.methodValueCall: nosplit stack over 792 byte limit
reflect.methodValueCall<0>
grows 448 bytes, calls reflect.moveMakeFuncArgPtrs<1>
grows 288 bytes, calls internal/abi.(*IntArgRegBitmap).Get<1>
grows 48 bytes, calls runtime.racefuncenter<1>
grows 0 bytes, calls racefuncenter<121>
grows 16 bytes, calls racecall<121>
grows 0 bytes, calls indirect
grows 0 bytes, calls runtime.morestack<0>
8 bytes over limit
ritbl
requested review from
BupycHuk,
artemgavrilov and
a team
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1314 /- ##
==========================================
- Coverage 43.64% 43.60% -0.04%
==========================================
Files 344 344
Lines 40458 40458
==========================================
- Hits 17656 17640 -16
- Misses 21279 21295 16
Partials 1523 1523
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| env-up: ## Start devcontainer. | ||
| COMPOSE_PROFILES=$(PROFILES) \ |
There was a problem hiding this comment.
do we really need to set it for each item?
can we extract it outside of items?
There was a problem hiding this comment.
I need to pass default profile (pmm), for some reason it does'n work with default
| @@ -27,3 27,5 @@ pmm-agent-dev.yaml | |||
|
|
|||
| # ViM temporary files | |||
| *.sw[o,p] | |||
|
|
|||
| .env | |||
There was a problem hiding this comment.
docker compose uses .env by default, it should not be committed
| @@ -2,7 2,9 @@ | |||
| version: '3.7' | |||
| services: | |||
| pmm-managed-server: | |||
There was a problem hiding this comment.
this section was not changed, only profiles section is added
ritbl
force-pushed
the
PMM-10900-custom-image-and-ch
branch
from
0df2d38 to
249267e
Compare
PMM-10900
Fully backward-compatible way to allow developers to override used Devcontainer and option to use external ClickHouse DB