Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note about non-public api #804

Merged
merged 4 commits into from
Mar 23, 2023
Merged

note about non-public api #804

merged 4 commits into from
Mar 23, 2023

Conversation

defbin
Copy link
Member

@defbin defbin commented Mar 16, 2023

mention about non-library repo

@defbin defbin requested a review from nastena1606 March 16, 2023 10:51
@defbin defbin requested a review from dAdAbird as a code owner March 16, 2023 10:51
Copy link
Member

@dAdAbird dAdAbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe it makes sense to emphasise this more, moving into a separate section.
Not sure if anybody will notice this note

README.md Outdated
@@ -44,6 44,9 @@ Find the installation instructions in the [official documentation](https://www.p

Alternatively, you can [run Percona Backup for MongoDB as a Docker container](https://hub.docker.com/r/percona/percona-backup-mongodb).

NOTE: The repo contains source code to build binaries. It is not a library and it is not intended to be used directly by calling exposed functions, types, etc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this note? What message do we want to say, and in what context? Perhaps this should be moved to the very top?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@JNKPercona
Copy link
Collaborator

Test name Logical Physical
Non-sharded psmdb 6.0 passed passed
New cluster psmdb 5.0 passed -
New cluster psmdb 4.2 passed -
Non-sharded psmdb 4.4 passed failed
Non-sharded psmdb 5.0 passed failed
Non-sharded psmdb 4.2 passed failed
New cluster psmdb 4.4 passed -
New cluster psmdb 6.0 failed -
Sharded psmdb 4.2 failed failed
Sharded psmdb 4.4 failed passed
Sharded psmdb 5.0 failed failed
Sharded psmdb 6.0 failed failed
Single-node psmdb 4.2 passed passed
Single-node psmdb 4.4 passed failed
Single-node psmdb 5.0 passed passed
Single-node psmdb 6.0 passed passed

defbin and others added 2 commits March 17, 2023 09:34
Co-authored-by: Anastasia Alexandrova <[email protected]>
Co-authored-by: Anastasia Alexandrova <[email protected]>
@defbin defbin requested review from dAdAbird and nastena1606 March 17, 2023 07:35
@JNKPercona
Copy link
Collaborator

Test name Logical Physical
Sharded psmdb 4.2 failed passed
Sharded psmdb 5.0 failed passed
Sharded psmdb 4.4 failed passed
New cluster psmdb 4.4 passed -
New cluster psmdb 4.2 passed -
Sharded psmdb 6.0 failed failed
New cluster psmdb 5.0 passed -
New cluster psmdb 6.0 failed -
Non-sharded psmdb 4.2 passed passed
Non-sharded psmdb 4.4 passed passed
Non-sharded psmdb 5.0 failed passed
Non-sharded psmdb 6.0 failed passed
Single-node psmdb 4.4 failed passed
Single-node psmdb 4.2 failed passed
Single-node psmdb 5.0 passed passed
Single-node psmdb 6.0 passed passed

README.md Outdated Show resolved Hide resolved
Co-authored-by: Andrew Pogrebnoi <[email protected]>
@defbin defbin requested a review from dAdAbird March 23, 2023 12:36
@defbin defbin merged commit d2e8a37 into main Mar 23, 2023
@defbin defbin deleted the no-api-readme branch March 23, 2023 15:07
@JNKPercona
Copy link
Collaborator

Test name Logical Physical
New cluster psmdb 4.2 passed -
Sharded psmdb 4.2 failed passed
Sharded psmdb 4.4 failed passed
Sharded psmdb 5.0 failed passed
Sharded psmdb 6.0 failed failed
New cluster psmdb 6.0 failed -
New cluster psmdb 5.0 passed -
Non-sharded psmdb 4.4 passed passed
Non-sharded psmdb 6.0 failed passed
New cluster psmdb 4.4 passed -
Non-sharded psmdb 5.0 failed passed
Single-node psmdb 4.2 failed passed
Single-node psmdb 5.0 passed passed
Single-node psmdb 6.0 passed passed
Single-node psmdb 4.4 failed passed
Non-sharded psmdb 4.2 failed passed

defbin added a commit that referenced this pull request Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants