chore: Rename module for v2 version #803
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Since v2.0.0 go module naming doesn't follow go recommendation (module should be named "github.com/percona/percona-backup-mongodb/v2") and can't be imported easily. For example in the mongodb operator: https://github.com/percona/percona-server-mongodb-operator/blob/v1.14.0/go.mod#L17
Go authors recommended for a while to create a v2/ folder and maintain several version of the code (https://go.dev/blog/v2-go-modules) but doesn't seem to reach a vast adhesion in the community. I personally - as many open source projects - prefer the approach to rename the module and the imports but keep the folder organization. Let me know what you think about it.
Sorry if it has already been discussed, I haven't found anything about it