Convert keyword elements correctly #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiasRosell
changed the title
pelme
requested changes
Sep 25, 2024
pelme
reviewed
Sep 26, 2024
MattiasRosell
commented
Sep 26, 2024
|
|
||
| @pytest.mark.parametrize( | ||
| ("element", "expected"), | ||
| [(imaginary, "<imaginary></imaginary>"), (imaginary_, "<imaginary-></imaginary->")], |
There was a problem hiding this comment.
Should underscore always be replaced with a hyphen like this?
MattiasRosell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
<del>tag was not converted into htpy'sdel_correctly. The formatters also can not handle importing python'sdelkeyword and would crash. Ruff would not output anything while Black would output the unformatted code.I fixed these issues by:
divwithdiv_when converting html using html2htpy.divis successfully converted todiv_.@pelme then found out that htpy did not convert the
del_element to html correctly. So we fixed that as well.del_element not converting into<del>correctly.