-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: forward messages with caption text #2272
base: main
Are you sure you want to change the base?
Conversation
- added ability to forward messages with original caption text
97aeff2
to
9456c65
Compare
I think if we change the default we should warn users about this before changing the default option. How would we inform them? |
Yes i was considering keeping the old functionality as the default, but then Pedro pointed out that forwarding messages with a caption is the default functionality provided by wweb themselves, and it seemed appropriate to me to have message forwarding work the same way for us too. In any case i mentioned in the documentation and usage example that the default functionality has been changed. Please let me know if you think something more needs to be done. |
Excellent work alechkos, I think when we merge this to the main branch we should inform users in discord. |
a452880
to
d58ee28
Compare
Important
breaking changeFix or feature that would cause existing functionality to change
Table of Contents
- Description
- Related Issues
- Usage Example
- I Want to Test this PR
- I Got an Error While Testing This PR ❌
- How Has the PR Been Tested (latest test on 01.05.2024)
- Types of Changes
Description
The PR introduces functionality that allows to forward media and attachment messages with their captions,
along with the ability to disable the
Forwarded
tag above a forwarded message.❗ Breaking Changes:
You can forward a message without a caption by setting an optional property
withCaption
tofalse
withinMessage.forward
method.Also you can turn off the
Forwarded
tag above a fowarded message by setting an optional propertydisplayAsForwarded
tofalse
.Related Issues
The PR closes #1650, closes #2426, closes #2435, closes #2629
Usage Example
To test this PR by yourself you should do two steps:
1. Install the PR by running one of the following commands:
2. Lock your WWeb version on 2.2412.54:
If you encounter any errors while testing this PR, please provide in a comment:
console.log(await client.getWWebVersion());
Important
You have to reapply the PR each time it is changed (new commits were pushed since your last application)
How Has The PR Been Tested (latest test on 01.05.2024)
The functionality has been tested by sending different types of messages:
Tested On:
Types of accounts:
Environment:
Types of Changes
Checklist