Validate requests before sending #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjab
commented
Aug 2, 2017
| be invalid. | ||
| """ | ||
| @spec new(URI.t, atom, any, headers) :: | ||
| {:ok, Request.t} | {:error, :invalid_uri} | {:error, :invalid_method} |
There was a problem hiding this comment.
I added typespecs here. I realize the rest of the codebase doesn't have them but I think it would be a good idea to add them as we go. I think it helps a ton with documentation. That said I can remove them if you would rather not go that direction.
cjab
commented
Aug 2, 2017
| @@ -6,6 6,48 @@ defmodule River.RequestTest do | |||
| { :ok, %{request: %Request{uri: URI.parse("https://google.com")}} } | |||
| end | |||
|
|
|||
| describe "Request.new/4" do | |||
There was a problem hiding this comment.
I also nested these tests in a describe block. The rest of the tests don't follow this pattern but it's something I'd like to propose. Again if you're against it I can unnest these :D.
There was a problem hiding this comment.
Not against this idea at all, in fact I much prefer organizing things this way.
|
This looks great, thanks @cjab! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an error when attempting to make a get request without an explicit path (no trailing slash).
I wrote a little bit of validation around creating requests that should set some reasonable defaults and return errors when the request is invalid.