Passing tests & Cleanup #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ssl_verify_fun package contains the most recent version, which relies on rebar3 instead of rebar, among other things.
|
Awesome, thank you! The tests currently hit the network, which is an inherently flaky thing to rely on, but it's been useful as I've been iterating on the code. On top of that, the request timeout code wasn't fully implemented, so you were probably getting timeouts on the gzip request. I'll give this a look today and merge it when I get a chance. Thanks again for the contribution! |
|
Makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I'd like to contribute to your work on a Elixir http/2 client as I've started myself a while ago.
First step was to get the tests reliably green on my machine as some of them were flaky and fix some credo warnings.
Let me know what you think.
Cheers.