Fixed error in walkdir #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 15, 2019 13:30
|
This is included in the 0.2.0 release: https://crates.io/crates/git-global/0.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! noticed that
git-globalwas not finding any repositories in my base directory because I had no ignored patterns.This was causing a
""to appear in theVec<String>matching all results. I added a.filter()line to match not on""and this works if you have no ignored patterns.I also version bumped app_dir to
1.2because1would not compile on MacOS (withstablerust).Finally, also version bumped
walkdirto2since it makes the.iter()a little cleaner. let me know what you think!Sorry the version bumps are bundled. If that's an issue I can put in different PRs :)