Improve campaign send performance #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pushchris
commented
Nov 3, 2024
pushchris
commented
- Reduce Redis memory usage by only enqueuing the most jobs that are possible over a given rate limit
- Allow for recovery of throttled jobs in the case of Redis running out of memory by re-adding them to the queue just like pending jobs
|
Hi @pushchris , this looks awesome. Is it ready to be tested? |
I mean, to actually get this commit and put it live so I can check how it behaves. |
|
@leobarcellos just merged in the changes, feel free to test |
|
Not sure if this error is related to this PR (but it seems to be)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.