Add node.js only parcel watcher watchman back-end #9789
Merged
320
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jdlm-stripe |
yamadapc
changed the title
yamadapc
force-pushed
the
pyamada-nodejs-watchman-watcher
branch
from
b00711b
to
5099a0d
Compare
marcins
reviewed
Jul 8, 2024
mattcompiles
changed the title
alshdavid
approved these changes
Aug 6, 2024
MonicaOlejniczak
approved these changes
Aug 6, 2024
devongovett
reviewed
Aug 6, 2024
packages/core/fs/package.json
Outdated
| @@ -48,6 48,8 @@ | |||
| "check-ts": "tsc --noEmit index.d.ts" | |||
| }, | |||
| "dependencies": { | |||
| "@parcel/feature-flags": "2.12.0", | |||
| "@parcel/watcher-watchman-js": "2.12.0", | |||
There was a problem hiding this comment.
How can we make this dependency opt-in? Peer dep? try...catch around a require?
There was a problem hiding this comment.
The package is so small (less than 50KB) that I wasn't going to worry about it. I can try make it opt in though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a commit over v2...jondlm:parcel:jdlm-watchman-drop-in-replacement
Migrated to typescript but need to write some tests and integrate with the rest of the codebase.The ignore patterns section likely is one thing that needs to be changed carefully though we could support only a subset of the current ignore options and delegate to watchman.Update
Ignore support added. Right now globs and directories are supported.