Only handle a create of the project root on Parcel startup #6644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
gorakong
force-pushed
the
gkong/build-loop
branch
from
66aeac1
to
908337f
Compare
wbinnssmith
suggested changes
Jul 26, 2021
There was a problem hiding this comment.
This should occur for one-off builds (i.e. not watch mode) as well. And it should occur in watch mode on the inital build only, not on the first set of fs changes (where it shouldn't happen at all). Probably should be around where we call getEventsSince?
cc @devongovett
devongovett
requested changes
Jul 27, 2021
gorakong
force-pushed
the
gkong/build-loop
branch
from
3aa5391
to
07a3f8a
Compare
wbinnssmith
reviewed
Jul 27, 2021
gorakong
force-pushed
the
gkong/build-loop
branch
from
07a3f8a
to
c708a55
Compare
gorakong
force-pushed
the
gkong/build-loop
branch
from
c708a55
to
adc752b
Compare
wbinnssmith
reviewed
Jul 27, 2021
wbinnssmith
reviewed
Jul 27, 2021
gorakong
force-pushed
the
gkong/build-loop
branch
3 times, most recently
from
e8fb742
to
0f0151c
Compare
wbinnssmith
approved these changes
Jul 27, 2021
wbinnssmith
reviewed
Jul 27, 2021
gorakong
force-pushed
the
gkong/build-loop
branch
from
0f0151c
to
898f9c0
Compare
|
lgtm. cc @devongovett |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constrains re-running of all requests in the RequestTracker to the initial build. Will be landed alongside parcel-bundler/watcher#57 to fix infinite build looping on the dev server caused by unknown flags triggering create events.
Test Plan